vrrp: fix segfault when instance has no interface configured

If a vrrp instance has no interface configured (so it is unicast), processing SIGUSR1 resulted ina segfault. Signed-off-by: Quentin Armitage <[email protected]>
acassen · Nov 24, 2024 · 2e2961d · 2e2961d
1 parent 99d2ea9
commit 2e2961d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/keepalived/vrrp/vrrp_data.c b/keepalived/vrrp/vrrp_data.c
@@ -685,7 +685,7 @@ dump_vrrp(FILE *fp, const vrrp_t *vrrp)
 	/* The following should only be specified for VMACs and ipvlans */
 	if (__test_bit(VRRP_VMAC_GROUP, &vrrp->flags))
 		conf_write(fp, "     Interface group %u", vrrp->vmac_group);
-	else if (vrrp->ifp->base_ifp->group)
+	else if (vrrp->ifp && vrrp->ifp->base_ifp->group)
 		conf_write(fp, "     Interface group %u (copied from parent)", vrrp->ifp->base_ifp->group);
 
 	if (vrrp->ifp && vrrp->ifp->is_ours) {