Reformat code #60
Closed
Reformat code #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FJShen
commented
Jun 27, 2023
src/gpgpu-sim/shader.cc
Outdated
There was a problem hiding this comment.
Honestly the "before" version looks better. But if we want to integrate pre-commit formatting in the github workflow, it's not worth creating an exception just for this piece of code.
|
Can we close this? The code is automatically formatted using actions. |
|
go ahead and close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue 207 in Accel-Sim: accel-sim/accel-sim-framework#207
The following pre-commit hooks are run on the repo:
Besides, some sporadic formatting imperfections are improved (e.g. non UTF-8 encoding, use of CRLF).
Finally, the pre-commit config file is added. For clang-format, the configuration file specifies exactly the same set of files outlined in format-code.sh