Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: resolves #233 & #234 #235

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat: resolves #233 & #234 #235

wants to merge 7 commits into from

Conversation

ctot-nondef
Copy link
Member

@ctot-nondef ctot-nondef commented Jan 29, 2025 •
edited
Loading

No description provided.

@ctot-nondef ctot-nondef linked an issue Jan 29, 2025 that may be closed by this pull request
collapse search accordion on search submit #234
Open
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-wibarab January 29, 2025 14:05 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-tunocent January 29, 2025 14:05 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-shawi January 29, 2025 14:05 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit January 29, 2025 14:05 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit January 29, 2025 14:13 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit January 29, 2025 14:21 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit January 29, 2025 14:24 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-wibarab January 29, 2025 14:24 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-tunocent January 29, 2025 14:24 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-shawi January 29, 2025 14:24 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit January 29, 2025 14:55 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-tunocent January 29, 2025 14:58 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-wibarab January 29, 2025 14:58 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit January 29, 2025 14:58 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-shawi January 29, 2025 14:58 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit-wibarab January 29, 2025 18:32 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit-shawi January 29, 2025 18:32 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit January 29, 2025 18:32 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit-tunocent January 29, 2025 18:32 — with GitHub Actions Inactive
@simar0at simar0at had a problem deploying to review/234-collapse-search-accordion-on-search-submit January 29, 2025 18:32 — with GitHub Actions Failure
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit January 29, 2025 18:32 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit-wibarab January 29, 2025 18:53 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit-tunocent January 29, 2025 18:53 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit January 29, 2025 18:53 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit-shawi January 29, 2025 18:53 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-shawi February 3, 2025 11:02 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit February 3, 2025 11:02 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit February 3, 2025 11:02 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-wibarab February 3, 2025 11:05 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-shawi February 3, 2025 11:05 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit February 3, 2025 11:05 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/234-collapse-search-accordion-on-search-submit-tunocent February 3, 2025 11:05 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/160-remove-tw-elements-again February 3, 2025 11:07 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/160-remove-tw-elements-again-wibarab February 3, 2025 11:07 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/160-remove-tw-elements-again-shawi February 3, 2025 11:07 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/160-remove-tw-elements-again-tunocent February 3, 2025 11:07 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef had a problem deploying to review/160-remove-tw-elements-again February 3, 2025 11:07 — with GitHub Actions Failure
@ctot-nondef ctot-nondef temporarily deployed to review/160-remove-tw-elements-again February 3, 2025 11:07 — with GitHub Actions Inactive
@ctot-nondef ctot-nondef temporarily deployed to review/160-remove-tw-elements-again February 3, 2025 11:20 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit-wibarab February 3, 2025 15:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit February 3, 2025 15:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit-shawi February 3, 2025 15:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit-tunocent February 3, 2025 15:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit February 3, 2025 15:02 — with GitHub Actions Inactive
@simar0at simar0at temporarily deployed to review/234-collapse-search-accordion-on-search-submit February 3, 2025 15:02 — with GitHub Actions Inactive
@simar0at
Copy link
Contributor

simar0at commented Feb 7, 2025

So now that I see it:

  • Second button should be Show on a map
  • I suggest we have the number of records below with the down array so the user can open the list.
    • I think we technically always get the list from the server but I would close it when the user selects the map option.
    • We may need to remember if the user clicked show list first and then not close the list.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar0at simar0at Awaiting requested review from simar0at

@dasch124 dasch124 Awaiting requested review from dasch124

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

collapse search accordion on search submit
3 participants
@ctot-nondef @dasch124 @simar0at