Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACE Explosives #80

Merged
merged 24 commits into from
Dec 11, 2024
Merged

Add ACE Explosives #80

merged 24 commits into from
Dec 11, 2024

Conversation

DerivenLoki
Copy link
Contributor

@DerivenLoki DerivenLoki commented Jun 28, 2024

When merged this pull request will:

  • Modifies the Mine.base prefabs MineDamageManager component, rendering gunfire unable to trigger the Trigger component
  • Adds the new ACE_Explosives_DeminingUserAction to the Mine.base Prefab to allow the use of a Shovel to disable Landmines
  • Modifies the existing ACE_Chopping_UserAction by adding a Parent Class - ACE_ShovelDestroyUserAction, found in ACE Core > Scripts > Game > UserActions - of which ACE_Chopping_UserAction now inherits from

Adds a Shovel prompt to disassemble landmines placed by players. Also makes landmines immune to Gunfire, in favor of this new change.
Tweaked the UserActions to appropriately reflect the new Class

Tweaked the Radius of the Action

Moved "HasLocalEffectOnlyScript" to Chopping_UserAction from ShovelDestroyUserAction
@Kexanone Kexanone changed the title Ace explosives Add ACE Explosives Jun 28, 2024
@Kexanone Kexanone added the kind/feature Release Notes: **ADDED:** label Jun 28, 2024
@Kexanone Kexanone added this to the 1.1.1 milestone Jun 28, 2024
String Table and Localization addition for the Mine Disarming action
Removed some unnecessary lines from each Script
Added my name to the list of Authors
Add Documentation
@Kexanone Kexanone modified the milestones: 1.1.1, 1.2.0 Jun 28, 2024
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will let Kex approve

@Kexanone Kexanone merged commit 2213241 into acemod:master Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants