-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACE Explosives #80
Merged
Merged
+776
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a Shovel prompt to disassemble landmines placed by players. Also makes landmines immune to Gunfire, in favor of this new change.
Tweaked the UserActions to appropriately reflect the new Class Tweaked the Radius of the Action Moved "HasLocalEffectOnlyScript" to Chopping_UserAction from ShovelDestroyUserAction
Kexanone
requested changes
Jun 28, 2024
addons/core/scripts/Game/ACE_Core/UserActions/ACE_ShovelDestroyUserAction.c
Outdated
Show resolved
Hide resolved
...losives/scripts/Game/ACE_Explosives/Demining/UserActions/ACE_Explosives_DeminingUserAction.c
Outdated
Show resolved
Hide resolved
String Table and Localization addition for the Mine Disarming action
Removed some unnecessary lines from each Script
Added my name to the list of Authors
Add Documentation
DerivenLoki
force-pushed
the
ACE-Explosives
branch
from
June 28, 2024 03:08
9b4f620
to
cad17c8
Compare
Changed ShovelDestroyUserAction to ShovelUserAction Changed WrenchDestroyUserAction to WrenchUserAction
Alphabetic order
Fix capitalization
…l into DerivenLoki-Explosives
…l into DerivenLoki-Explosives
veteran29
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I will let Kex approve
Kexanone
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Mine.base
prefabsMineDamageManager
component, rendering gunfire unable to trigger the Trigger componentACE_Explosives_DeminingUserAction
to theMine.base
Prefab to allow the use of a Shovel to disable LandminesACE_Chopping_UserAction
by adding a Parent Class -ACE_ShovelDestroyUserAction
, found in ACE Core > Scripts > Game > UserActions - of whichACE_Chopping_UserAction
now inherits from