-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical - Add medication dosage support & improve overdose #10393
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Grim <[email protected]>
…into Overdose-Rework
addons/medical_status/functions/fnc_addMedicationAdjustment.sqf
Outdated
Show resolved
Hide resolved
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
addons/medical_status/functions/fnc_addMedicationAdjustment.sqf
Outdated
Show resolved
Hide resolved
Don't worry about the failing pboProject build. Do worry about HEMTT warnings/errors though. |
_return | ||
TRACE_5("getMedicationCount",_target,_medication,_getCount,_return,_medDose); | ||
|
||
[_medication, _medDose, _return] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why return one of the inputs here? If it's for the other functions' sake, modify its return instead IMO
if (!isNil "_onOverDose" && {isText _onOverDose}) then { | ||
_onOverDose = compile _onOverDose; | ||
} else { | ||
_onOverDose = missionNamespace getVariable _onOverDose; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't work, getText will never return nil and isText will always be true
Should've just started a review. |
*/ | ||
|
||
params ["_unit", "_classname"]; | ||
private _medicationConfig = configFile >> "ace_medical_treatment" >> _classname; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you actually intend on dropping support for root-level onOverDose?
Also, won't work.
private _medicationConfig = configFile >> "ace_medical_treatment" >> _classname; | |
private _medicationConfig = configFile >> "ace_medical_treatment" >> "Medication"; |
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.