Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explosives - Use detonator icon for consolidated detonate actions #10394

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Explosives - Use detonator icon for consolidated detonate actions #10394

merged 4 commits into from
Oct 15, 2024

Conversation

mrschick
Copy link
Contributor

@mrschick mrschick commented Oct 11, 2024 •
edited
Loading

When merged this pull request will:

  • Prevent consolidated detonate actions from using the same icon as consolidated place actions of the same explosive type, which bore the potential for confusing them and mistakenly triggering the explosive.
    ui-change

@PabstMirror PabstMirror added this to the 3.18.2 milestone Oct 15, 2024
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Oct 15, 2024
@LinkIsGrim LinkIsGrim merged commit 54150b9 into acemod:master Oct 15, 2024
3 of 4 checks passed
@mrschick mrschick deleted the feature/consolidated-trigger-icons branch October 15, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnb432 johnb432 johnb432 left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.
4 participants
@mrschick @PabstMirror @johnb432 @LinkIsGrim