Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goggles - Notify restart req. for effects setting #10398

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Goggles - Notify restart req. for effects setting #10398

merged 1 commit into from
Oct 15, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • This setting doesn't set anything up if the setting is turned off at the start.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Oct 12, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Oct 12, 2024
@PabstMirror
Copy link
Contributor

I think you just need to turn NVGS off and on again for the new setting to apply

@johnb432
Copy link
Contributor Author

I think you just need to turn NVGS off and on again for the new setting to apply

This is the goggles overlay, not the NVG overlay we're talking about.

@PabstMirror PabstMirror merged commit dcc314c into master Oct 15, 2024
3 of 4 checks passed
@PabstMirror PabstMirror deleted the goggles-restart-req-notification branch October 15, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.
2 participants
@johnb432 @PabstMirror