-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overpressure - Add editor range attribute for vehicles #10411
base: master
Are you sure you want to change the base?
Conversation
note: doesnt work yet
it works fine now
Why are all the tabs failing OH MY GOD |
TODO:
|
Okay, I fixed EVERYTHING - This PR is ready for review & merge. |
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
Good catch |
Signed-off-by: bluefield <[email protected]>
private _unitOverpressureRangeAttribute = _unit getVariable QEGVAR(overpressure,distance); | ||
|
||
// If -1 (disabled) we return to server value, otherwise we use the given value. | ||
_dangerZoneRange = _dangerZoneRange * [_unitOverpressureRangeAttribute, GVAR(overpressureDistanceCoefficient)] select (_unitOverpressureRangeAttribute < 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
help[L-S12]: Invalid Args - [B:*]
┌─ addons/overpressure/functions/fnc_firedEHOP.sqf:29:37
you are multiplying a number times an array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot parentheses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not working
Co-authored-by: Grim <[email protected]>
Co-authored-by: Grim <[email protected]>
@@ -8,7 +8,7 @@ class CfgPatches { | |||
requiredVersion = REQUIRED_VERSION; | |||
requiredAddons[] = {"ace_common"}; | |||
author = ECSTRING(common,ACETeam); | |||
authors[] = {"commy2","KoffeinFlummi","esteldunedain"}; | |||
authors[] = {"commy2","KoffeinFlummi","esteldunedain", "bluefield"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is reserved for people who have contributed significantly in either the creation or the refactoring of a component, https://github.com/acemod/ACE3/blob/master/AUTHORS.txt would be more appropriate for this PR.
When merged this pull request will:
Problem: if the user has the server setting set to 10 (example) and a mission maker wants to set a vehicle's value to 0, it wont work. Since we check for >= 0.1I cant figure out a good system other than making an entire new overpressure setting called "enable overpressure" as a checkbox instead of the range slider.There might be some use cases where a user may want to disable overpressure on some vehicles, and change the values of others, which would require both... so I might update this in the future to add such use case.Important bits of code: cfgEden.hpp & fnc_firedEHOP.sqf
2nd ever PR i appreciate all feedback. 🥲
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.