Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explosives - Add Tripwire Flare Air Variant #10423

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Oct 15, 2024

When merged this pull request will:

  • Adds a new tripflare item that fires into the sky instead of on the ground.
  • Adds setting for the tripflare colour (default is Red, which i think is what the original one did. Not sure, colourblind.)
  • Kept the old tripflare class for BWC, just no longer used here.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

I'd prefer to just add a 2nd magazine instead of a setting

@Mike-MF
Copy link
Member Author

Mike-MF commented Oct 16, 2024

I'd prefer to just add a 2nd magazine instead of a setting

That'd mean duplicated code as the effect only passes the position, so no way of detecting what kind of flare would have been activated. The setting is just the simpler solution here.

@Drofseh
Copy link
Contributor

Drofseh commented Oct 16, 2024

By having a setting and changing it to air mode, all mission that have been previous made with ground flares now have air flares. I don't think that's desirable
As a mission maker I might like to be able to give players a mix of ground and air flares, or places a mix in a defended area in the editor.

I don't see a lot of duplicate code being added to implement that. A couple of additions to CfgCloudlets.hpp and something like TripflareAirEffect.sqf that adds a little height to the initial Z position when calling the spawnFlare function.

@Mike-MF Mike-MF changed the title Explosives - Add air mode to tripflares Explosives - Add Tripwire Flare Air Variant Oct 16, 2024
@johnb432
Copy link
Contributor

I'm not a huge fan of having the color be a setting. Is there no way we can have it passed as an argument or set as a config entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants