Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Add Regex patterns in PBO check whitelist #10778

Merged
merged 7 commits into from
Mar 22, 2025

Conversation

Timi007
Copy link
Contributor

@Timi007 Timi007 commented Mar 6, 2025

When merged this pull request will:

  • Allow Regex patterns in PBO check whitelist
  • Ignore checking A3 CuratorOnly_ addons

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Timi007 added 2 commits March 6, 2025 00:56

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Jouni Järvinen <[email protected]>
Timi007 and others added 4 commits March 8, 2025 15:01

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Mar 16, 2025
private _addon = _x;

(_addon select [0, 3] != "a3_") &&
{_addon select [0, 4] != "ace_"} &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not matter for this pr, but should we skip acex as well?

@PabstMirror PabstMirror modified the milestones: 3.19.2, Ongoing, 3.19.3 Mar 18, 2025
@PabstMirror PabstMirror merged commit d132ef4 into acemod:master Mar 22, 2025
3 checks passed
@Timi007 Timi007 deleted the pbo_check_regex branch March 22, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants