Common - Use canAdd for FUNC(addToInventory) #9830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we be using the 2.18 syntax everywhere, including individual container checks? I can't get a clear picture from the discord messages related to the changes (https://discord.com/channels/105462288051380224/108187245529268224/1193267882751176785) and the wiki page (https://community.bistudio.com/wiki/canAdd), but the feeling I'm getting is that we should. EDIT: No, above isn't a concern. |
johnb432
approved these changes
Oct 13, 2024
PabstMirror
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Works alright, and arsenal already uses it on containers. This is faster and takes allowedSlots into account.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.