Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookoff - Use getShotInfo for tracer detection #9911

Closed
wants to merge 41 commits into from
Closed

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Apr 2, 2024

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the 2.18 label Apr 2, 2024
@johnb432 johnb432 removed the 2.18 label Oct 12, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Oct 12, 2024
@johnb432 johnb432 added the kind/optimization Release Notes: **IMPROVED:** label Oct 12, 2024
@johnb432 johnb432 removed this from the 3.18.2 milestone Oct 12, 2024
@johnb432 johnb432 removed the kind/optimization Release Notes: **IMPROVED:** label Oct 12, 2024
@johnb432
Copy link
Contributor Author

_ammo getShotInfo 4 can't be used, as _ammo is the classname and not the object. We could try to use the HitPart EH, but locality weirdness with that EH is an issue, since HitPart triggers even if allowDamage is false, meaning we'd need to check it manually and given it's local command, we'd need to send events over the network every time.
TLDR: not worth it.

@johnb432 johnb432 closed this Oct 12, 2024
@johnb432 johnb432 deleted the cookoff-tracer branch October 12, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants