use USER env and create svc with yaml instead of expose + other changes #526

splattner · 2023-03-03T07:14:41Z

No description provided.

github-actions · 2023-03-03T07:25:47Z

PR environments:

with curl instead of browser & change local deploy yaml to match for replicas

tl edit in attaching a database

splattner · 2023-03-03T10:49:49Z

content/en/docs/additional-concepts/sidecar-containers/_index.md

@@ -25,28 +25,23 @@ In a sidecar pattern, the functionality of the main container is extended or enh
 In {{<link "persistent-storage">}} you created a MariaDB deployment. In this task you are going to add the [Prometheus MySQL exporter](https://github.com/prometheus/mysqld_exporter) to it.

 {{% onlyWhenNot openshift %}}


shall I change this also for OpenShift?

What exactly?

Ah, in the overview it didn't show the following changes. We can also change this in OpenShift, that's ok, thanks.

And this is also changed in the oc variants

bliemli · 2023-03-23T07:52:50Z

Why use $USER if you mean the namespace? The username doesn't necessarily have to be the namespace.

Or even better, use placeholders that can be set via URL parameters instead of letting the user set env vars. The reason for this is, depending on the training, we have different naming conventions, especially if we are on customer-provided infrastructure.

bliemli

I couldn't yet review all of it and will certainly have to test all the changes in more detail, but these are my first suggestions.

bliemli · 2023-03-23T14:51:30Z

content/en/docs/exposing-a-service/_index.md


 ```bash
-{{% param cliToolName %}} expose deployment example-web-go --type=ClusterIP --name=example-web-go --port=5000 --target-port=5000 --namespace <namespace>


In my opinion it's important to know these helper commands as they facilitate editing resources and belong to a basics training. At a later time the resources are then saved as files in order to adopt a gitops approach.

If I remember correctly we once discussed, that we wan't to get rid of these imperative commands. Not sure if you were involved in this discussion though. In my opinion the --dry-run=client -o yaml approach is the nicer one to create resources for the gitops approach. But I guess for expose there is not relly an equivalent.
Maybee also something to quickly discuss/align in a S1 Stream meeting.

We could also use oc create route. However, this only works for secured routes, so we'd need to make sure all OpenShift training variants are run on a cluster that offers a proper wildcard certificate or cert-manager that handles these. Up until now this is the case.

I added the expose command again as a second option.

content/en/docs/exposing-a-service/_index.md

content/en/docs/scaling/_index.md

splattner · 2023-04-20T11:26:29Z

Why use $USER if you mean the namespace? The username doesn't necessarily have to be the namespace.

Or even better, use placeholders that can be set via URL parameters instead of letting the user set env vars. The reason for this is, depending on the training, we have different naming conventions, especially if we are on customer-provided infrastructure.

@schlapzz (acend/helm-basics-training#395) already used this in the helm training, so I reused it from there. Also $USER is set in the webshell and so the trainees can simply copy/paste it.
We should use the same scheme in all training. Let's align on this in a S1 Stream meeting or update day

schlapzz · 2023-04-22T11:58:59Z

As Seba already mentioned, we're make heavy use of this Env Var in our Trainings ($LAB_USER in AMM Techlab, later renamed in the Helm & ArgoCD Techlab from $STUDENT to $USER, see here and later here

The naming of the var is not that important for me. But regarding the new Training Cluster setup it would be nice if we use the same Var Name for all trainings 💙

bliemli · 2023-05-25T08:58:54Z

As Seba already mentioned, we're make heavy use of this Env Var in our Trainings ($LAB_USER in AMM Techlab, later renamed in the Helm & ArgoCD Techlab from $STUDENT to $USER, see here and later here

The naming of the var is not that important for me. But regarding the new Training Cluster setup it would be nice if we use the same Var Name for all trainings blue_heart

Still, the best option imho would be to use a placeholder as described here. This doesn't require setting an environment variable on the terminal and is widely used in the Kubernetes Basics training.

splattner · 2023-07-03T11:14:54Z

I replaced <namespace> with $USER using the placeholder feature and I also introduced a placeholder for appdomain.

use USER env and create svc with yaml instead of expose

7fccd35

splattner requested review from bliemli, sybnex and verysonglaa March 3, 2023 07:14

splattner added 2 commits March 3, 2023 08:15

spit set env in attaching database

9510749

update hugo mod dependencies

a0ba02c

fix sidecar

4aeae48

with curl instead of browser & change local deploy yaml to match for replicas

splattner changed the title ~~use USER env and create svc with yaml instead of expose~~ use USER env and create svc with yaml instead of expose + other changes Mar 3, 2023

splattner added 4 commits March 3, 2023 11:39

remove kubec

8217623

tl edit in attaching a database

update hugo mods again

eb46019

also use apply instead of edit in the persistent-storage lab

0cd6a5c

also use apply instead of edit in the sidecar lab

c1d7db9

splattner commented Mar 3, 2023

View reviewed changes

splattner added 5 commits March 3, 2023 12:32

also use apply instead of edit in the init container lab

2c40b90

specify path to ingress.yaml

8fcc267

remove line in nodeport service

89481a5

add note to nodeport lab

dd77b8d

scaling lab: apply the serice as file instead of the expose command

59c5290

splattner force-pushed the no-more-imperative-and-more branch from 6cf9b35 to 59c5290 Compare March 3, 2023 11:47

use yaml instead of edit in scaling lab

6cac131

splattner force-pushed the no-more-imperative-and-more branch from 4466b0c to 6cac131 Compare March 3, 2023 11:56

splattner added 4 commits March 3, 2023 12:59

get url for sclaing test from ingress

ce46882

fix scaling lab include

3436830

get ingress with kubectl in scaling

2bd0cc0

Merge branch 'main' into no-more-imperative-and-more

6531422

bliemli reviewed Mar 24, 2023

View reviewed changes

Merge branch 'main' into no-more-imperative-and-more

9832a1b

splattner force-pushed the no-more-imperative-and-more branch from 2b0e242 to b1e2fe0 Compare April 20, 2023 11:33

rephrasing and use hightlight shortcode

7a00943

splattner force-pushed the no-more-imperative-and-more branch from b1e2fe0 to 7a00943 Compare April 20, 2023 11:36

splattner added 3 commits July 3, 2023 12:47

Merge branch 'main' into no-more-imperative-and-more

11b1ac3

use params replace feature

9c738db

use params for appdomain also in default config

c90fbf4

splattner added 3 commits July 3, 2023 13:20

change <domain> to <appdomain> to be used with the placeholder

0d98c60

add expose command again as altenate

537d381

change sidecar lab and also use apply in openshift variants

dc70d14

splattner force-pushed the no-more-imperative-and-more branch from e07e571 to dc70d14 Compare July 3, 2023 13:12

fix expose command section

640b94a

bliemli approved these changes Aug 7, 2023

View reviewed changes

splattner merged commit 380fe43 into main Aug 7, 2023

splattner deleted the no-more-imperative-and-more branch August 7, 2023 13:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use USER env and create svc with yaml instead of expose + other changes #526

use USER env and create svc with yaml instead of expose + other changes #526

splattner commented Mar 3, 2023

github-actions bot commented Mar 3, 2023 •

edited

Loading

splattner Mar 3, 2023

bliemli Mar 23, 2023

bliemli Mar 23, 2023

splattner Jul 3, 2023

bliemli commented Mar 23, 2023 •

edited

Loading

bliemli left a comment

bliemli Mar 23, 2023

splattner Apr 20, 2023

bliemli May 25, 2023

splattner Jul 3, 2023

splattner commented Apr 20, 2023 •

edited

Loading

schlapzz commented Apr 22, 2023 •

edited

Loading

bliemli commented May 25, 2023

splattner commented Jul 3, 2023

		@@ -25,28 +25,23 @@ In a sidecar pattern, the functionality of the main container is extended or enh
		In {{<link "persistent-storage">}} you created a MariaDB deployment. In this task you are going to add the [Prometheus MySQL exporter](https://github.com/prometheus/mysqld_exporter) to it.

		{{% onlyWhenNot openshift %}}


		```bash
		{{% param cliToolName %}} expose deployment example-web-go --type=ClusterIP --name=example-web-go --port=5000 --target-port=5000 --namespace <namespace>

use USER env and create svc with yaml instead of expose + other changes #526

use USER env and create svc with yaml instead of expose + other changes #526

Conversation

splattner commented Mar 3, 2023

github-actions bot commented Mar 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bliemli commented Mar 23, 2023 • edited Loading

bliemli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

splattner commented Apr 20, 2023 • edited Loading

schlapzz commented Apr 22, 2023 • edited Loading

bliemli commented May 25, 2023

splattner commented Jul 3, 2023

github-actions bot commented Mar 3, 2023 •

edited

Loading

bliemli commented Mar 23, 2023 •

edited

Loading

splattner commented Apr 20, 2023 •

edited

Loading

schlapzz commented Apr 22, 2023 •

edited

Loading