Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure the homepage code #387

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

YoshithaRathnayake
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake commented Feb 2, 2022

Purpose

The purpose of this PR is to fix #358

Goals

Restructuring the homepage code

Approach

I restructured the homepage code

Screenshots

No screenshots

Preview Link

https://yoshitharathnayake.github.io/sack-site/

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Piumal1999
Copy link
Member

@YoshithaRathnayake The aim of the mentioned issue is to create a better code structure. You can refer the material kit starter template for that.
Or you can use a template like this:

<!-- Header -->
...
<!-- end of Header -->

<div class="main>
    <div class="section">
        // content of section 1
    </div>

    <div class="section">
        // content of section 2
    </div>

    ...other sections...

    <div class="section contact-section">
        // content of contact section
    </div>
</div>

And there are some custom styles that we could directly add using bootstrap classes without using custom CSS.
Example:
Currently we have a custom padding (padding-bottom: 40px, padding-top: 40px) for the contact-section. Without using that custom css, we could directly use py-5 CSS class to add that padding.

@YoshithaRathnayake
Copy link
Member Author

YoshithaRathnayake commented Feb 2, 2022

I think that one is making from this pr #388 @Piumal1999

@YoshithaRathnayake
Copy link
Member Author

Now @Piumal1999

@YoshithaRathnayake
Copy link
Member Author

Is that the way wanted

index.html Outdated
<!-- End of Resource Section -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end of line is missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @YoshithaRathnayake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure the homepage code
3 participants