Add support for region serialization and turn chunk into NBT #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested in Minecraft: the game seems to run fine after region (-1, -1) deserialized and then serialized back. Signed-off-by: Pavel Kretov <[email protected]>
Also remove 'test*' methods, to convert them in future into proper unit tests. Signed-off-by: Pavel Kretov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not completely ready, I just need some feedback.
Hi! I want to create a simple level generator for Minecraft (for scientific purposes, despite it sounds crazy) and during my investigation I found your Data.NBT library on Hackage and this project on your GitHub. Unfortunately, it lacked support for serializing chunks and region, while having support for deserializing, so I've decided to write it by myself. Here is the intermediate result, you may not like it, because I'm not as monadic person as you, but I tried my best.
I want also to propose some more improvements:
Data.MinecraftLevel?), currentGame.Minecraftreads as if it were Minecraft game itself.