tlist() should return list #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make a trivial example that shows the bad thing happening? |
|
Thanks, Greg, and sorry for the delay on this! I just tried manually overwriting the scan_table and using the scan_gather=True option in obs.tlist(), and the current code returned a tlist of length 1, but indeed obs.tlist()[0] was not of the right datatype. I agree reverting to a list for the output of obs.tlist() would fix this issue, but I think the output of obs.tlist() has to be an array for eh.self_cal() function to work. I will check this and try to find a solution. In any case, thank you for pointing this out and I will try to fix it asap! |
|
I created a new python environment with python==3.9, then did "pip install ehtim". Afterwards, assuming I've got the "EHT2017.txt" array file, run Error at obs.add_all() and observing obs.tlist(), the recarray has lost its column attributes. So indexing by the attribute fails. I note that this particular issue doesn't appear if I run inside a clone of the eht-imaging GitHub repository. Result/traceback from the above: |
…elds This commit adds the 'w' coordinate to the polarization data structures and observation fields in the `const_def.py` file. The 'w' coordinate represents the third dimension in the UVW coordinate system. This addition allows for the representation of three-dimensional data in polarization calculations. Additionally, the `recompute_uv` method in the `Obsdata` class in the `obsdata.py` file has been modified to include the 'w' coordinate when recomputing the u,v points using observation times and metadata. The modification allows for the computation of three-dimensional u,v,w coordinates for an array at a given time for a source at a given ra, dec, and rf. The `compute_uv_coordinates` function in the `obs_helpers.py` file has also been updated to include the 'w' coordinate in the computation of u,v,w coordinates for an array at a given time for a source at a given ra, dec, and rf. Lastly, the `make_uvpoints` function in the `obs_simulate.py` file has been modified to include the 'w' coordinate in the generated UV points. This modification allows for the generation of three-dimensional UVW points for simulated observations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method comments suggest that tlist() should return list. If the observation has only one scan, or if all scans have the same shape, np.array(datalist, dtype=object) can produce a bug, i.e. when you run the add_all() method, because the tlist can't be indexed by the array attribute.