Throw an appropriate exception when user provides an empty object ver…

…sion ID (noobaa#7970) * Throw an appropriate exception when a user provides an empty object version ID * Only evaluate the length of `version_id` if an ID exists Signed-off-by: Ben <[email protected]>
achouhan09 · Apr 16, 2024 · 92f9cd5 · 92f9cd5
1 parent dbe81f9
commit 92f9cd5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/endpoint/s3/ops/s3_get_object.js b/src/endpoint/s3/ops/s3_get_object.js
@@ -59,6 +59,9 @@ async function get_object(req, res) {
         md_conditions,
         encryption,
     };
+    if (params.version_id?.length === 0) {
+        throw new S3Error(S3Error.InvalidArgumentEmptyVersionId);
+    }
     if (md_params.get_from_cache) {
         params.get_from_cache = true;
     }

diff --git a/src/endpoint/s3/s3_errors.js b/src/endpoint/s3/s3_errors.js
@@ -144,6 +144,11 @@ S3Error.InvalidArgument = Object.freeze({
     message: 'Invalid Argument',
     http_code: 400,
 });
+S3Error.InvalidArgumentEmptyVersionId = Object.freeze({
+    code: 'InvalidArgument',
+    message: 'Version id cannot be the empty string',
+    http_code: 400,
+});
 S3Error.InvalidBucketName = Object.freeze({
     code: 'InvalidBucketName',
     message: 'The specified bucket is not valid.',