ci: use nix shells to build #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jakubgs
reviewed
Aug 20, 2024
Jenkinsfile
Outdated
| sh 'yarn build' | ||
| jenkins.genBuildMetaJSON('build/build.json') | ||
| nix.develop('yarn build') | ||
| jenkins.genBuildMetaJSON('dist/build.json') |
There was a problem hiding this comment.
Why are we changing the output dir name?
There was a problem hiding this comment.
Its like that in some other repos so wanted to be the same Jenkinsfile for all but can revert to original
There was a problem hiding this comment.
But wouldn't you have to modify the build setup to build into that folder and not build?
There was a problem hiding this comment.
Was this ever verified that the path is correct? Seems wrong to me.
There was a problem hiding this comment.
It is wrong. Changed to correct path.
mendelskiv93
force-pushed
the
nix-build
branch
from
a60cfc9
to
df7c147
Compare
jakubgs
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: