Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fathom analytics #202

Merged
merged 3 commits into from
Oct 25, 2023
Merged

feat: add fathom analytics #202

merged 3 commits into from
Oct 25, 2023

Conversation

jinhojang6
Copy link
Collaborator

Description:

Add fathom analytics as per request

Changes Included:

  • Bugfix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Refactoring (a change that improves code quality and/or architecture)
  • Other (explain below)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@jinhojang6 jinhojang6 self-assigned this Oct 5, 2023
@vercel
Copy link

vercel bot commented Oct 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lpe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 2:36pm

@jinhojang6 jinhojang6 closed this Oct 13, 2023
@jinhojang6 jinhojang6 reopened this Oct 24, 2023
@jinhojang6
Copy link
Collaborator Author

@jeangovil Reopened the PR as per request

jeangovil
jeangovil suggested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@jeangovil jeangovil left a comment •
edited by jinhojang6
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinhojang6,

  • The trackPageview should be triggered upon route changes as well.
  • the siteId, and the script URL should come from the env vars, you can set a default value for each in the .env file.

@jinhojang6
Copy link
Collaborator Author

@jeangovil Thanks for the brief. I've added a commit. Can you please take a look?

jeangovil
jeangovil reviewed Oct 25, 2023
View reviewed changes
types/fathom.d.ts Outdated Show resolved Hide resolved
@jinhojang6 jinhojang6 merged commit 030239d into develop Oct 25, 2023
4 checks passed
@jinhojang6 jinhojang6 deleted the add-fathom branch October 25, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeangovil jeangovil jeangovil approved these changes

Assignees

@jinhojang6 jinhojang6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinhojang6 @jeangovil