Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates UI for the e-mail subscription form #210

Closed
wants to merge 1 commit into from

Conversation

jongomez
Copy link
Contributor

@jongomez jongomez commented Oct 23, 2023

Description:

Creates UI for the e-mail subscription form.

Figma link

Related Issue(s):

#206

Changes Included:

  • Bugfix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Refactoring (a change that improves code quality and/or architecture)
  • Other (explain below)

Implementation Details:

Simple subscription react component. The onSubmit logic was not implemented yet. But, I added a prop to the component in case we want to define this from the parent component.

Testing:

For testing, I added this component to the article footer. This was done locally, and is not included in this PR.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Here's what it looks like:

Screenshot from 2023-10-23 13-20-05

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lpe ✅ Ready (Inspect) Visit Preview Oct 23, 2023 0:28am

@jongomez
Copy link
Contributor Author

Closing this for now - as we went with another design:

#211

@jongomez jongomez closed this Oct 26, 2023
@jongomez jongomez mentioned this pull request Oct 26, 2023
2 tasks
@jeangovil jeangovil deleted the subscribe-form branch December 1, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant