Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Document for Custom User Model #48

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ZhangChen199102
Copy link
Contributor

Created ADR for the custom User model introduced by #47

Copy link
Contributor

@a-musing-moose a-musing-moose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fine - a couple of extra paragraph to give a little more information about you have been doing with the custom user model would, I think, help clarify things.

I have added suggestions in line.

docs/decisions/0003-custom-user-model.md Show resolved Hide resolved

## Decision

We will use a custom User model instead of using Django built-in User model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: ‏Can we also state here that the custom model will be based on the built in one and provide all the same features?

@ZhangChen199102 ZhangChen199102 force-pushed the add-document-for-custom-user-model branch 2 times, most recently from 49d4bfb to b933d37 Compare April 12, 2024 04:44
Comment on lines 32 to 33
change and evolve that model later one. Something this is a lot more difficult should
we stick with the built in one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo:

Suggested change
change and evolve that model later one. Something this is a lot more difficult should
we stick with the built in one.
change and evolve that model later one. Something that is a lot more difficult should
we stick with the built in one.

Sorry, this one is my fault.

@ZhangChen199102 ZhangChen199102 force-pushed the add-document-for-custom-user-model branch from b933d37 to 7a4183c Compare April 14, 2024 07:06
@ZhangChen199102 ZhangChen199102 merged commit 7159cfa into main Apr 15, 2024
1 check passed
@ZhangChen199102 ZhangChen199102 deleted the add-document-for-custom-user-model branch April 15, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants