Addings poetry caching to CI #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahraaalizadeh
approved these changes
Jul 12, 2024
template/.github/workflows/ci.yml
Outdated
| @@ -32,19 +34,22 @@ jobs: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Install managment tools | |||
There was a problem hiding this comment.
managment > management
| @@ -32,19 +34,22 @@ jobs: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Install managment tools | |||
| run: pipx install poetry && pipx install invoke | |||
There was a problem hiding this comment.
Question - Do we need to ensure that pipx is installed and available in the CI env?
There was a problem hiding this comment.
Apparently not - it is installed by default. This approach is how the setup-python actions recommends using Poetry.
template/.github/workflows/ci.yml
Outdated
| @@ -53,14 +58,17 @@ jobs: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Install managment tools | |||
template/.github/workflows/ci.yml
Outdated
| @@ -97,10 +105,14 @@ jobs: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Install managment tools | |||
template/.github/workflows/ci.yml
Outdated
| @@ -143,10 +154,14 @@ jobs: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Install managment tools | |||
template/.github/workflows/ci.yml
Outdated
| @@ -197,14 +215,14 @@ jobs: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Install managment tools | |||
template/.github/workflows/ci.yml
Outdated
| @@ -10,20 +10,22 @@ jobs: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Install managment tools | |||
The setup-python command has built in support for poetry. Somewhat confusingly it requires that poetry be installed _before_ `setup-python` is run. So that is what we do here - using the recommended approach of using pipx to install it.
a-musing-moose
force-pushed
the
ci-caching
branch
from
51f6a68
to
ff6f0a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup-python command has built in support for poetry. Somewhat confusingly it requires that poetry be installed before
setup-pythonis run. So that is what we do here - using the recommended approach of using pipx to install it.