Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BoardCard & Board Component #109

Merged
merged 8 commits into from
Feb 3, 2025
Merged

Add BoardCard & Board Component #109

merged 8 commits into from
Feb 3, 2025

Conversation

wesleylwu
Copy link
Collaborator

image

@wesleylwu wesleylwu added the help wanted Extra attention is needed label Feb 2, 2025
@wesleylwu wesleylwu self-assigned this Feb 2, 2025
@wesleylwu wesleylwu linked an issue Feb 2, 2025 that may be closed by this pull request
@wesleylwu
Copy link
Collaborator Author

am i approaching this right so far? im struggling to align the photos with the borders as well as making the images of the board members not cover the border.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the other colored diamonds will need to be added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks right

@@ -0,0 +1,21 @@
"use client";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, also this file should be a tsx file

Comment on lines 9 to 15
{boardInfo.map((CARD) => (
<BoardCard
name={CARD.name}
title={CARD.title}
image={CARD.image}
color={CARD.color}
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you're assigning a key to every mapped CARD.

Comment on lines 15 to 21
<Image
src={image}
alt="picture of person"
className="absolute object-cover"
width={300}
height={300}
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need to be positioned absolutely within a relative diamond. to make your photo into a diamond feel free to copy this code into the globals.css file and you can use it by typing diamond into the tailwind css classnames

.diamond {
	-webkit-clip-path: polygon(50% 0, 100% 50%, 50% 100%, 0 50%);
	clip-path: polygon(50% 0, 100% 50%, 50% 100%, 0 50%);
}

tsconfig.json Outdated
Comment on lines 30 to 31
"src/components/board/Board.js",
"src/components/board/BoardCard.js"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove since you should be using tsx files

Comment on lines +200 to +205
// {
// image: Stephanie,
// name: "Stephanie Huang",
// title: "Academic Chair",
// color: "csa-yellow-300",
// },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why'd you comment this out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be a tsx file

@stanleylew5 stanleylew5 added changes requested and removed help wanted Extra attention is needed labels Feb 2, 2025
@stanleylew5
Copy link
Contributor

am i approaching this right so far? im struggling to align the photos with the borders as well as making the images of the board members not cover the border.

the diamond should be relatively positioned, and the photo of the officers should be absolutely positioned within it

@wesleylwu
Copy link
Collaborator Author

wesleylwu commented Feb 2, 2025

image
also i wasn't sure if there was a purpose for color so i didn't include it as a prop

Copy link
Contributor

@stanleylew5 stanleylew5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm we might need to add in diff image components based on image since they're all diff dimensions but that's a later problem!

@stanleylew5 stanleylew5 merged commit c677abc into dev Feb 3, 2025
5 checks passed
@stanleylew5 stanleylew5 deleted the wesleylwu/Board branch February 3, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BoardCard & Board Component
2 participants