Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed mission statement issue #28

Merged
merged 8 commits into from
Jan 19, 2025
Merged

Conversation

exitcy
Copy link
Collaborator

@exitcy exitcy commented Jan 15, 2025

image

@exitcy exitcy requested a review from stanleylew5 January 15, 2025 23:55
@exitcy exitcy self-assigned this Jan 15, 2025
@exitcy exitcy linked an issue Jan 16, 2025 that may be closed by this pull request
return (
<div className="px-8 py-4">
<div className="border-l-8 border-csa-tan-300 pl-6">
<p className="mb-4 text-left text-4xl font-bold text-csa-red-100">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this text slightly larger

@exitcy
Copy link
Collaborator Author

exitcy commented Jan 16, 2025

image
made text slightly larger

Copy link
Contributor

@stanleylew5 stanleylew5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull from dev and then make sure your component is called above all the other content on the page right now so it matches the figma

@stanleylew5
Copy link
Contributor

You have a merge conflict to solve as well

@@ -0,0 +1,24 @@
import React from "react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import React from "react";

return (
<div className="px-8 py-4">
<div className="border-l-8 border-csa-tan-300 pl-6">
<p className="mb-0 text-left text-5xl font-bold text-csa-red-100">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p className="mb-0 text-left text-5xl font-bold text-csa-red-100">
<p className="text-left text-5xl font-bold text-csa-red-100">

Copy link
Contributor

@stanleylew5 stanleylew5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stanleylew5 stanleylew5 merged commit 08c7cc1 into dev Jan 19, 2025
5 checks passed
@stanleylew5 stanleylew5 deleted the exitcy/missionstatement branch January 19, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mission Statement
2 participants