Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grid for xin description #48

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Add grid for xin description #48

merged 6 commits into from
Jan 24, 2025

Conversation

brenda-rg
Copy link
Collaborator

image

  • Added a grid to the xin description
  • Added xin image to the xin description
  • Added xin image as an svg

@brenda-rg brenda-rg self-assigned this Jan 21, 2025
@brenda-rg brenda-rg linked an issue Jan 21, 2025 that may be closed by this pull request
grid for xin description #33
Closed
VacaTheCow
VacaTheCow requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@VacaTheCow VacaTheCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Brenda, theres an issue here where if you start scrolling the xin image goes up with it. When we start adding more info to the website this will be a problem.
image

@brenda-rg
Copy link
Collaborator Author

brenda-rg commented Jan 22, 2025 •
edited
Loading

Screenshot (242)

  • Pulled from dev and fixed the image overlapping with the nav bar issue.
  • Extra text only to show above issue (not in code)

stanleylew5
stanleylew5 requested changes Jan 23, 2025
View reviewed changes
src/components/home/XinDescription.tsx Outdated Show resolved Hide resolved
src/components/home/XinDescription.tsx Outdated Show resolved Hide resolved
@brenda-rg
Copy link
Collaborator Author

image

  • Fixed height and width properties from comments

stanleylew5
stanleylew5 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@stanleylew5 stanleylew5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stanleylew5 stanleylew5 merged commit f2c4123 into dev Jan 24, 2025
5 checks passed
@stanleylew5 stanleylew5 deleted the brenda-rg/xinGrid branch January 24, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VacaTheCow VacaTheCow VacaTheCow requested changes

@stanleylew5 stanleylew5 stanleylew5 approved these changes

@agoel27 agoel27 Awaiting requested review from agoel27

Assignees

@brenda-rg brenda-rg

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grid for xin description
3 participants
@brenda-rg @VacaTheCow @stanleylew5