dragon on left #53
Open
dragon on left #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
|
stanleylew5
requested changes
Jan 23, 2025
src/app/page.tsx
Outdated
| <div className="bg-csa-tan-100"> | ||
| <div className="grid grid-flow-col grid-rows-3 gap-4"> | ||
| <Image | ||
| src="/home/dragon.png" |
There was a problem hiding this comment.
Suggested change
| src="/home/dragon.png" | |
| src="/home/dragon.png" |
Import it at the top as so --
Import Dragon from "@/public/home/dragon.png"
then your src here will just be src={Dragon}
src/app/page.tsx
Outdated
Comment on lines
15
to
16
| width={450} | ||
| height={450} |
There was a problem hiding this comment.
don't hardcode these properties
src/app/page.tsx
Outdated
| <div className="bg-csa-tan-100 pt-[12.2vh] md:pt-[14.4vh]"> | ||
| <MissionStatement /> | ||
| <div className="bg-csa-tan-100"> | ||
| <div className="grid grid-flow-col grid-rows-3 gap-4"> |
There was a problem hiding this comment.
Suggested change
| <div className="grid grid-flow-col grid-rows-3 gap-4"> | |
| <div className="grid grid-flow-col grid-rows-3 gap-4"> |
you're doing a lot of extra work than you need to, all you have to do is absolutely position the dragon to the left side of the page
Update Images to Webp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.