Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join Now! button added home page #18

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

achan618
Copy link
Collaborator

Screenshot 2025-01-11 at 6 50 53 PM

Comment on lines 4 to 6
<div className="flex items-center justify-center text-[10vw] text-cvdsa-red-200">
example
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all my example code

@@ -1,8 +1,15 @@
const example = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename component and make sure you edit the name when exported

example
</div>
<div className="flex items-center justify-center">
<button className="mt-56 rounded-full border px-6 py-2 text-3xl">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button className="mt-56 rounded-full border px-6 py-2 text-3xl">
<button className="rounded-full border px-6 py-2 text-3xl">

add a shadow below the button -- reference the figma, I think the shadow is only below the button and not any other angle

@stanleylew5
Copy link
Contributor

Remember to link your issue
image

@achan618 achan618 linked an issue Jan 13, 2025 that may be closed by this pull request
@achan618
Copy link
Collaborator Author

Screenshot 2025-01-13 at 11 39 52 AM

Copy link
Contributor

@stanleylew5 stanleylew5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stanleylew5 stanleylew5 merged commit ec95b3c into dev Jan 13, 2025
5 checks passed
@stanleylew5 stanleylew5 deleted the AndrewChan/homejoinbutton branch January 13, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

home page join button
2 participants