Jsimj001/home page secondary text #25
Conversation
…orrect BG and text color, and the font looks slightly different than the figma
tailwind.config.ts
Outdated
| "white-255": "FFFFFF", | ||
| "black-255": "000000", |
There was a problem hiding this comment.
| "white-255": "FFFFFF", | |
| "black-255": "000000", |
remove this, there are already classes on tailwind for this
tailwind.config.ts
Outdated
| fontFamily: { | ||
| 'cvdsa-Montserrat-sans': [ | ||
| 'Montserrat', | ||
| 'sans-serif', | ||
| ], | ||
| }, |
There was a problem hiding this comment.
remove this too, montserrat is the default font of the repository. if you can't see it, then that means you need to make sure your dev branch is up to date and pull from dev
| fontFamily: { | |
| 'cvdsa-Montserrat-sans': [ | |
| 'Montserrat', | |
| 'sans-serif', | |
| ], | |
| }, |
src/components/home/example.tsx
Outdated
|
|
||
| // Comments by Jameel: | ||
| // Where I found these sources: | ||
| // Fonts: https://tailwindcss.com/docs/font-family |
There was a problem hiding this comment.
remove comments
| // Comments by Jameel: | |
| // Where I found these sources: | |
| // Fonts: https://tailwindcss.com/docs/font-family |
src/components/home/example.tsx
Outdated
| <div className=" | ||
| text-5x1/48.76 | ||
| font-cvdsa-Montserrat-sans | ||
| font-[500] | ||
| flex h-screen w-screen items-center text-center mx-auto justify-center | ||
| text-[4vw] | ||
| text-cvdsa-white-255"> |
There was a problem hiding this comment.
| <div className=" | |
| text-5x1/48.76 | |
| font-cvdsa-Montserrat-sans | |
| font-[500] | |
| flex h-screen w-screen items-center text-center mx-auto justify-center | |
| text-[4vw] | |
| text-cvdsa-white-255"> | |
| <div className=" | |
| flex h-screen w-screen items-center text-center mx-auto justify-center | |
| text-[4vw] "> |
just a rough approximation of the font is fine, it doesn't need to be crazy. if text-5xl looks close enough to the figma, you can use that. montserrat is the default font, remove those styles. the color white is already added within tailwind as text-white
|
Link your issue and assign the pr to yourself |
|
Make sure you add the respective labels too |
|
I have applied the requested changes from this pull request comment chain. Please review them and let me know of any required changes, so that I can work on the next issue accordingly. |
JSimjee
dismissed
stanleylew5’s stale review
the requested change has been resolved locally, the merge conflict was resolved
src/components/home/homepage.tsx
Outdated
| @@ -0,0 +1,9 @@ | |||
| const HomePage = () => { | |||
| return ( | |||
| <div className="mx-auto flex h-screen w-screen items-center justify-center text-center text-[4vw] text-black"> | |||
There was a problem hiding this comment.
| <div className="mx-auto flex h-screen w-screen items-center justify-center text-center text-[4vw] text-black"> | |
| <div className="mx-auto flex w-screen items-center justify-center text-center text-[4vw] text-black"> |
style the text a bit more so the distance to the main text and size relative to the main text match the figma; looks good otherwise
The font type is still somewhat different than what the figma shows, and I'm not sure whether we are supposed to implement the white font color, but I could not get that working anyway.
I made a new fontFamily in the tailwind.config.ts file as well.