secondary text research #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asirmazhar23
changed the title
stanleylew5
requested changes
Jan 17, 2025
| return <div>research comps here</div>; | ||
| return ( | ||
| <div> | ||
| {" "} |
There was a problem hiding this comment.
Suggested change
| {" "} | |
src/app/research/page.tsx
Outdated
| return ( | ||
| <div> | ||
| {" "} | ||
| <SecondaryText />{" "} |
There was a problem hiding this comment.
Suggested change
| <SecondaryText />{" "} | |
| <SecondaryText /> |
| @@ -0,0 +1,9 @@ | |||
| const SecondaryText = () => { | |||
| return ( | |||
| <p className="align-center text-center font-seasons text-[30px]"> | |||
There was a problem hiding this comment.
Suggested change
| <p className="align-center text-center font-seasons text-[30px]"> | |
| <p className="text-center font-seasons text-[30px]"> |
Use flex justify-center and don't hardcode a text value, just use a tailwind class that looks close enough for now. we'll worry about responsiveness later
|
Link your issue |
stanleylew5
requested changes
Jan 31, 2025
| const SecondaryText = () => { | ||
| return ( | ||
| <p className="align-center flex justify-center text-center font-seasons text-xl"> | ||
| Click on these for more information |
There was a problem hiding this comment.
this text does not accurately match what the issue requests for. the text should be 'Click on these for access to more resources! '
There was a problem hiding this comment.
you'll need two p tags one for the text on top and bottom
Co-authored-by: Stanley Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I matched the font size to the best of my ability :)