-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phoebe/research page banner #43
Conversation
phoebezhou222
commented
Jan 20, 2025
•
edited
Loading
edited
![image](https://private-user-images.githubusercontent.com/188874473/405417219-68892f38-6d59-4dd5-be80-c5415d3702ac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNzk1MDUsIm5iZiI6MTczOTE3OTIwNSwicGF0aCI6Ii8xODg4NzQ0NzMvNDA1NDE3MjE5LTY4ODkyZjM4LTZkNTktNGRkNS1iZTgwLWM1NDE1ZDM3MDJhYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQwOTIwMDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01OGM2NjVlNDgxZmFmNDg4MTRkODhlNGY4Y2UwMDNlMGU4MjZjOTg5ZDVhY2NiM2NmMTdmYzY5ZWVmMmZkNDYyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.zgFThrJPwVLrMokJ4gq1aQONI9a86IpfU2ij_7FHazg)
src/components/research/page.tsx
Outdated
return ( | ||
<> | ||
<div> | ||
<img src="/research/rectangle8.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<img src="/research/rectangle8.png" /> | |
<img className="w-screen aspect-[5/1]" src="/research/rectangle8.png" /> |
style the img so it matches the relative size on the figma
make sure to call the component in the correct page; currently, both the research components are being called in the home page. please move them to src/app/research/page.tsx |
also, make sure to appropriately name images; you can just rename rectangle8 to researchbanner or something similar |
public/research/rectangle8.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this image
return ( | ||
<> | ||
<div> | ||
<img className="aspect-[5/1] w-screen" src="/research/rectangle8.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Image tag from next/image instead of HTML img tag
return ( | ||
<> | ||
<div> | ||
<img className="aspect-[5/1] w-screen" src="/research/rectangle8.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import this image as well it should be something like
`import { ResearchBanner } from "@/public/research/researchbanner.webp"
<div> | ||
<Image | ||
src={ResearchConference} | ||
className="aspect-[5/1] w-screen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className="aspect-[5/1] w-screen" | |
className="w-screen" |
src/app/research/page.tsx
Outdated
<Research /> | ||
<ResearchImage /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call research image above the research component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!