Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blurb for home page #45

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

add blurb for home page #45

wants to merge 11 commits into from

Conversation

cwu423
Copy link
Collaborator

@cwu423 cwu423 commented Jan 20, 2025

Screenshot 2025-01-20 at 11 43 39 AM

@cwu423 cwu423 self-assigned this Jan 20, 2025
@cwu423 cwu423 linked an issue Jan 20, 2025 that may be closed by this pull request
<div className="flex w-[30vw] flex-col items-center">
<div>
<Image
src="/home/blurbforhome.jpeg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src="/home/blurbforhome.jpeg"
src="/home/blurbforhome.jpeg"

Import this image, ex:
Import { Cupcakes } from "@/public/home/cupcakes.jpeg" or something like that and then the source of your image would be src="Cupcakes"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know this would work!

Comment on lines 9 to 10
width={310}
height={500}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tailwind to modify width/height values, let's not use hardcoded values either, use % or vw

src/components/home/BlurbHome.tsx Outdated Show resolved Hide resolved
width={310}
height={500}
alt="Picture for blurb"
className="aspect-[363/376] rounded-[15%] border-2 border-slate-400/60"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tailwind colors instead of border-slate, etc., if the photo was cropped weirdly you might need to crop the original photo yourself to match the figma and then add it into the repository. let's not mess with weird aspect values haha. there's many online photocroppers you can use for free.

Copy link
Contributor

@stanleylew5 stanleylew5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops meant to request changes not comment

@cwu423
Copy link
Collaborator Author

cwu423 commented Jan 21, 2025

fixed!

Copy link
Contributor

@stanleylew5 stanleylew5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes were not pushed to github

@minhhdtran
Copy link
Contributor

run git pull origin cwu423/BlurbHome and npm run format, then push to origin; the runner seemed to have caused some formatting issues. code looks good otherwise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement blurb for home page
3 participants