-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add blurb for home page #45
base: dev
Are you sure you want to change the base?
Conversation
cwu423
commented
Jan 20, 2025
src/components/home/BlurbHome.tsx
Outdated
<div className="flex w-[30vw] flex-col items-center"> | ||
<div> | ||
<Image | ||
src="/home/blurbforhome.jpeg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src="/home/blurbforhome.jpeg" | |
src="/home/blurbforhome.jpeg" |
Import this image, ex:
Import { Cupcakes } from "@/public/home/cupcakes.jpeg" or something like that and then the source of your image would be src="Cupcakes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know this would work!
src/components/home/BlurbHome.tsx
Outdated
width={310} | ||
height={500} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use tailwind to modify width/height values, let's not use hardcoded values either, use % or vw
src/components/home/BlurbHome.tsx
Outdated
width={310} | ||
height={500} | ||
alt="Picture for blurb" | ||
className="aspect-[363/376] rounded-[15%] border-2 border-slate-400/60" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use tailwind colors instead of border-slate, etc., if the photo was cropped weirdly you might need to crop the original photo yourself to match the figma and then add it into the repository. let's not mess with weird aspect values haha. there's many online photocroppers you can use for free.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops meant to request changes not comment
fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes were not pushed to github
Update Images to Webp
run git pull origin cwu423/BlurbHome and npm run format, then push to origin; the runner seemed to have caused some formatting issues. code looks good otherwise! |