socials banner image update #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
v1viant12
commented
Jan 29, 2025
v1viant12
commented
Closed
minhhdtran
reviewed
Jan 29, 2025
src/app/socials/page.tsx
Outdated
| @@ -1,5 +1,11 @@ | |||
| const Socials = () => { | |||
| return <div>socials comps here</div>; | |||
| import Social from "@/components/socials/Social"; | |||
There was a problem hiding this comment.
Suggested change
| import Social from "@/components/socials/Social"; | |
| import SocialBanner from "@/components/socials/Social"; |
update the name for clarity; there's going to be more comps called here
stanleylew5
requested changes
Jan 31, 2025
src/components/socials/Social.tsx
Outdated
|
|
||
| const SocialBanner = () => { | ||
| return ( | ||
| <div className="relative flex w-full overflow-hidden"> |
There was a problem hiding this comment.
Suggested change
| <div className="relative flex w-full overflow-hidden"> | |
| <div className="w-full"> |
all those classes do nothing so remove them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.