-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Timeweb Cloud DNS API #5141
Conversation
Welcome |
Ready for review. |
1998567
to
418b37e
Compare
907ce1a
to
10cfc68
Compare
I've made some corrections and signed the squashed commit. I’m eagerly awaiting your approval, @Neilpang. |
TW_Page_Offset=0 | ||
|
||
while [ -z "$TW_Dns_Records_Total" ] || | ||
[ "$((TW_Dns_Records_Total + TW_Page_Limit))" -gt "$((TW_Page_Offset + TW_Page_Limit))" ]; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this never gets called if there are more than 100 domains. Loop always stops on the first page because the TW API always sets TW_Domains_Total = 100. For example, the condition $((TW_Dns_Records_Total + TW_Page_Limit))
will be assigned 100..200..200..200.. and the condition $((TW_Page_Offset + TW_Page_Limit))
will be assigned 100..200..300..400..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mistakenly thought that "total" in the meta
section of the API response referred to the total number of records on the server, not the number of returned records. Well, I’ll fix the pagination in the domain and DNS record request functions. Thanks for the clarification, @damel
Hi there! Thanks for the great work on the acme.sh script! I really appreciate it. Could you please consider adding the Timeweb Cloud DNS API from this pull request?
Issues & bugs
Instruction