Updates dns_cyon txt_body and adds validation #6097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome |
InteractiveNinja
force-pushed
the
master
branch
from
b4b7f11
to
2c0820b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I recently attempted to update my domains certificate via acme.sh, but encountered issues with the txt validation.
After some debugging, I found at that the form body had changed a little.
Changes
zone➡️namevalue➡️dnscontentI also added a validation for the response being returned after the update, in hopes that it will actually bail if the update fails.
I didn't try it, but I think it should work.
Thanks for this great tool, and also thanks for maintaining support for cyon domains 👍