Skip to content

Visual and Style Fixes #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"react-icons": "^4.10.1",
"react-remark": "^2.1.0",
"react-router-dom": "^5.1.2",
"react-scripts": "^5.0.0",
"react-scripts": "^5.0.1",
"request": "^2.88.2"
},
"scripts": {
Expand Down
5 changes: 2 additions & 3 deletions src/components/EventCard/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,12 @@ const EventCard = ({ event }: { event: ACMEvent }) => {
return (
<>
<div className="EventCard">
<Row>
<Row align="middle">
<img
src={event.cover}
alt={event.title}
style={{
marginBottom: '1.5rem',
marginRight: '1rem',
marginRight: '2rem',
boxShadow: '0px 3px 5px 1px rgba(189, 189, 189, 0.5)',
borderRadius: '16px',
height: '88px',
Expand Down
5 changes: 5 additions & 0 deletions src/components/Header/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@
p {
font-weight: @semi-bold;
}

h4 {
font-weight: @semi-bold;;
color: white;
}

}
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/Header/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ function Header() {
history.push('/');
}}
>
<p>Login</p>
<h4>Login</h4>
</Button>
</Link>
)}
Expand Down
15 changes: 13 additions & 2 deletions src/components/MainFooter/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,21 @@ import React from 'react';
import './index.less';
import { AiOutlineLink } from 'react-icons/ai';
import { BiLogoInstagram, BiLogoDiscord, BiMailSend } from 'react-icons/bi';
const { Footer } = Layout;
import '../../newStyles/components.less'
const { Footer, Content } = Layout;

const MainFooter = () => {
interface MainFooterProps {
isMainPage?: boolean;
}

const MainFooter: React.FC<MainFooterProps> = ({ isMainPage = false }) => {
return (
<>
<Content>
<div className=" gradient-bar"></div>
</Content>
<Footer className="mainFooter">
{/* <Footer className={`mainFooter ${isMainPage ? '' : 'gradient-bar'}`}> */}
<Row className="splitRow">
<Col className="infoText">
<h2 className="title2">Join the board</h2>
Expand Down Expand Up @@ -100,6 +110,7 @@ const MainFooter = () => {

<h3>ACM AI at UC San Diego</h3>
</Footer>
</>
);
};

Expand Down
2 changes: 1 addition & 1 deletion src/components/ProjectCard/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,4 @@

}

}
}
3 changes: 0 additions & 3 deletions src/pages/404Page/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ function NotFound() {
</div>
</Content>

<Content>
<div className="homeBottomBar"></div>
</Content>
<MainFooter />
</DefaultLayout>

Expand Down
2 changes: 1 addition & 1 deletion src/pages/AboutPage/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@
}

h4 {
margin-top: 1rem;
font-weight: @semi-bold;
}

Expand Down Expand Up @@ -210,7 +211,6 @@
background: white;
height: 35px;
width: 35px;
box-shadow: 0px 3px 5px 1px rgba(189, 189, 189, 0.5);
}

a {
Expand Down
4 changes: 2 additions & 2 deletions src/pages/AboutPage/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ function AboutPage() {
>
<div className="drawerContent">
<Col>
<Row className="drawerHeader">
<Row className="drawerHeader" gutter={[16, { xs: 8, sm: 16, md: 24, lg: 32 }]}>
<img
style={{
marginRight: '1rem',
Expand All @@ -291,7 +291,7 @@ function AboutPage() {
alt={`profile of ${selectedPerson!!.name}`}
/>
<Col className="titleBox">
<Tag bordered={false} color={'error'}>
<Tag bordered={false} color={'error'} >
{selectedPerson!!.role}
</Tag>
<h4>{selectedPerson!!.name}</h4>
Expand Down
51 changes: 21 additions & 30 deletions src/pages/EventsPage/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@
}

.eventsContent {

.generic-section();
.constrained-bounds();
margin-bottom: 10rem;

.ant-tabs-ink-bar {
display: none;
Expand All @@ -54,39 +52,32 @@
}
}


// Custom Footer for Events Page
.eventsFooter {
width: 100%;
min-width: 180px;
background-color: @black;
color: @white;

padding-left: @padding-base2;
padding-right: @padding-base2;

@media screen and (max-width: @xs) {
padding-left: @padding-base !important;
padding-right: @padding-base !important;
.eventsFAQ {
.generic-section();
h3 {
font-weight: bold;
line-height: 3rem;
}


.row {
padding: @padding-base;
margin-top: @margin-base;
.splitInfoRow {
display: flex;
align-items: center;
margin-bottom: 4rem;
max-width: @lg;

max-width: 80%;
.constrained-bounds();

h4, h2, p{
color: @white;
.infoText {
flex: 1 1 50%;
max-width: 80%;
padding: @padding-base2;

.infoButton {
margin-top: @margin-base;
margin-bottom: @margin-base;
.button-colorful();
}
}

}
h3 {
@color: @white;
text-align: center;

}
}

}
53 changes: 24 additions & 29 deletions src/pages/EventsPage/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ import {
} from '../../actions/events';
import { Row, Col, Layout, Tabs } from 'antd';
import EventCard from '../../components/EventCard/index';
const { Content, Footer } = Layout;
import MainFooter from '../../components/MainFooter';
const { Content } = Layout;

const newEvents = (eventData: ACMEvent[]): React.ReactNode => {
return (
Expand Down Expand Up @@ -84,43 +85,37 @@ function EventsPage(props: any) {
]}
></Tabs>
</Content>

<Footer className="eventsFooter">
<Row className="row">
<Col>
<h2 className="title2">What events do we run?</h2>
<Content className="eventsFAQ">
<Row className="splitInfoRow">
<Col className="infoText">
<h3> What events does <span className="colorful">ACM AI</span> run?</h3>
<p>
We run all kinds of events, from intro to deep learning
workshops to seminars from distinguished researchers and
professors. Events are a great way to engage with the AI
community at UCSD and learn content you may not typically learn
in class! We also have a running contest ranking on Discord
based on your performance on our latest Kahoot quizzes. We often
host these quizzes at the start or end of a workshop.
We run all kinds of events, from intro to deep learning workshops to fun socials or
seminars from distinguished researchers and professors.
Events are a great way to engage with the AI community at UCSD and learn content
you may not typically learn in class.

Join the conversation on Discord to learn more!
</p>
</Col>
</Row>

<Row className="row">
<Col>
<h2 className="title2">Where can I find past workshops?</h2>
<Row className="splitInfoRow">
<Col className="infoText">
<h3>Where can I find past events</h3>
<p>
We post all of our workshop recordings on our YouTube at{' '}
<a
href="https://acmurl.com/youtube"
target="_blank"
rel="noopener noreferrer"
>
https://acmurl.com/youtube
</a>
. Stay tuned in our Discord for uploads!
We post all of our workshop recordings on our YouTube at {' '}
<a href="https://acmurl.com/youtube" target="_blank" rel="noopener noreferrer">
https://acmurl.com/youtube
</a>.
Stay tuned in our Discord for uploads!
</p>
</Col>
</Row>

<h3>ACM AI at UCSD 2023</h3>
</Footer>
</Content>
</Content>

<MainFooter />
</DefaultLayout>
);
}
Expand Down
12 changes: 1 addition & 11 deletions src/pages/MainPage/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@
background-color: #FFF8F8;
max-width: 80%;
padding: 3rem 5rem;
margin-bottom: 3rem;
gap: 10rem;

.items {
Expand Down Expand Up @@ -217,14 +218,3 @@
background-clip: text; /* For Firefox */
color: transparent;
}

.homeBottomBar {
box-sizing: border-box;
background: linear-gradient(to right, #F66161, #FE7C37);
border: 0px solid transparent;
background-clip: padding-box, border-box;
background-origin: padding-box, border-box;
padding: 3rem;
margin-top: 10rem;
}

9 changes: 3 additions & 6 deletions src/pages/MainPage/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const { Content } = Layout;
function MainPage() {
return (
<DefaultLayout>

<Content className="homeHeader">
<div className="homeContent">
<div className="homeText">
Expand All @@ -29,6 +30,7 @@ function MainPage() {
<Button size="large" shape="round" className="aboutButton">Sign up for our newsletter &gt;</Button>
</Link>
</div>

</div>
<img src={AILogo} alt="ACM AI Diamond Logo" className="ai-logo"/>
<div className="floatingShapes">
Expand Down Expand Up @@ -115,12 +117,7 @@ function MainPage() {
</div>
</Content>



<Content>
<div className="homeBottomBar"></div>
</Content>
<MainFooter />
<MainFooter isMainPage={true} />

</DefaultLayout>
)
Expand Down