Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move university dropdown to application form #70

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

SheepTester
Copy link
Member

@SheepTester SheepTester commented Jan 14, 2025

Info

Closes #69.

Description

Moves the university dropdown from the register page to the application form

Changes

  • Removed the unused university dropdown from the register page
  • Added a university question to the application form
  • Dietary is set to "Will be answered in follow-up form." rather than being undefined (which for some reason exempts the column from being validated on the backend)
  • A missing file upload now shows the "Required" error

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

image

image

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackathon-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 9:03pm

Copy link

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

@SheepTester SheepTester merged commit 054c7d1 into main Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: Remove university prompt from register page
2 participants