Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update psycopg2 to 2.9.10 #18

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Update psycopg2 to 2.9.10 #18

merged 1 commit into from
Dec 6, 2024

Conversation

bttf
Copy link
Contributor

@bttf bttf commented Dec 4, 2024

Ran into an issue with psycopg2 during poetry install on a fresh clone. Updating to 2.9.10 fixed the issue. Seems harmless since it is only a patch version bump. Let me know if I can better shape this PR. Thanks.

Copy link
Member

@lalinsky lalinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, could you please do the one change with re-adding the ^ in there?

pyproject.toml Outdated
@@ -8,7 +8,7 @@ license = "MIT"

[tool.poetry.dependencies]
python = "^3.8"
psycopg2 = "^2.9.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still leave the ^ there, it tells poetry that any higher version (until the next major one) is OK.

If you ran poetry update psycopg2 I think it would do that by default.

@bttf
Copy link
Contributor Author

bttf commented Dec 6, 2024

Thank you for the PR, could you please do the one change with re-adding the ^ in there?

Added it back in. For context, I ran poetry add psycopg=2.9.10 without caret which explains why it was left out.

@bttf
Copy link
Contributor Author

bttf commented Dec 6, 2024

Some weird errors came about - redid changes from clean slate and simply ran poetry update psycopg2.

@lalinsky
Copy link
Member

lalinsky commented Dec 6, 2024

Perfect, thank you!

@lalinsky lalinsky closed this Dec 6, 2024
@lalinsky lalinsky reopened this Dec 6, 2024
@lalinsky lalinsky merged commit 50d8766 into acoustid:main Dec 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants