Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a test, updating CI #4

Merged
merged 24 commits into from
Mar 5, 2025
Merged

Adding a test, updating CI #4

merged 24 commits into from
Mar 5, 2025

Conversation

aarohiprasad
Copy link

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

@aarohiprasad aarohiprasad changed the title CallbackSubscriber Test SparkpostTransportTest Feb 13, 2025
@aarohiprasad aarohiprasad force-pushed the remove-email-bounced-designation branch from 3eb20c7 to 0764b9d Compare February 14, 2025 08:41
@aarohiprasad
Copy link
Author

The CI CD is failing since this code contains reference to classes which are present in mc-cs repo. I am not sure how to proceed on this. Any thoughts @escopecz @dadarya0 ?

@aarohiprasad aarohiprasad requested review from a team, avikarshasaha and dadarya0 and removed request for a team February 14, 2025 09:30
@aarohiprasad
Copy link
Author

Requesting review since this will eventually be needing some refactoring after unforking

@avikarshasaha avikarshasaha removed their request for review February 17, 2025 07:30
@aarohiprasad aarohiprasad force-pushed the remove-email-bounced-designation branch from ca657be to 4c01bed Compare February 18, 2025 14:43
@aarohiprasad aarohiprasad force-pushed the remove-email-bounced-designation branch from 3776352 to 07def90 Compare February 18, 2025 15:57
@aarohiprasad aarohiprasad force-pushed the remove-email-bounced-designation branch from 479255e to 74fbade Compare February 18, 2025 16:13
@aarohiprasad aarohiprasad requested review from a team and fedys and removed request for a team February 18, 2025 16:14
@aarohiprasad aarohiprasad force-pushed the remove-email-bounced-designation branch from 285e7f4 to 1828756 Compare February 27, 2025 16:08
@escopecz escopecz changed the title SparkpostTransportTest Adding a test, updating CI Feb 28, 2025
@escopecz escopecz mentioned this pull request Feb 28, 2025
Merged
@escopecz
Copy link

I've returned the failing assertions back and created a fix for the bug here: mautic/mautic#14661

fedys
fedys approved these changes Mar 3, 2025
View reviewed changes
Copy link

@fedys fedys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aarohiprasad and @escopecz!

dadarya0
dadarya0 approved these changes Mar 4, 2025
View reviewed changes
Copy link

@dadarya0 dadarya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR have only test cases so no testing required.

@escopecz
Copy link

escopecz commented Mar 5, 2025

This was closed by merging mautic/mautic#14661.

@escopecz escopecz reopened this Mar 5, 2025
@escopecz escopecz merged commit bae016d into main Mar 5, 2025
1 check passed
@escopecz escopecz deleted the remove-email-bounced-designation branch March 5, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedys fedys fedys approved these changes

@dadarya0 dadarya0 dadarya0 approved these changes

@escopecz escopecz Awaiting requested review from escopecz

Assignees

@dadarya0 dadarya0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aarohiprasad @escopecz @fedys @dadarya0 @avikarshasaha