Vectorized file writes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliddell
force-pushed
the
vector-writes
branch
from
fe238af to
d70ca8e
Compare
jeskesen
requested changes
Dec 5, 2024
Actually they don't belong there. Those are artifacts from something I was trying but discarded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a class which takes a
std::vector<std::span<std::byte>>>&and writes the contents of each span in a vectorized fashion to the filesystem. Includes some system-dependent code because of course it does.Also adds benchmarking code so that we can test streaming performance before and after this change.