forked from muun/apollo
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go version #10
Open
acrespo
wants to merge
12
commits into
master
Choose a base branch
from
fix-gomobile-setup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bump go version #10
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ad25e07
Bump go version
acrespo 725a91e
Fix build problem during gomobile gobind exec
acrespo 40997e4
Apollo: fix gomobile setup issue
acrespo b9b9d80
Apollo: try full package fix
acrespo d44ca89
Apollo: run go get github.com/muun/libwallet
acrespo e69daa0
Apollo: run go get golang.org/x/mobile/cmd/[email protected]…
acrespo 848f91a
Apollo: new extra param is required in gomobile invocation
acrespo 755137c
Revert "Fix build problem during gomobile gobind exec"
acrespo 4347b65
Run go mod tidy + go get golang.org/x/mobile/cmd/gomobile
acrespo 1ba63cb
Replace darbelo personal fork ref with muun official gombile fork
acrespo 71a547e
Rm go.sum no longer needed entries
acrespo e396b54
Mv bootstrap-gomobile.sh to libwallet-android.sh
acrespo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ RUN apt-get update \ | |
curl \ | ||
git \ | ||
zip \ | ||
build-essential\ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably need to find a way to fix the gcc version. this will download "latest" which can differ between runs of the dockerfile and cause non-reproducible builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We believe this is no longer needed, we introduced this to fix a compiling error before trying out the "full"/rebased changes from upstream. Those include a commit where they no longer try to compile certain files before hand. Will try removing this