Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support swipe animations #1135

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

msvalandro
Copy link

@msvalandro msvalandro commented Feb 5, 2025

  • update README with instructions to run the app locally
  • install dependencies for swipe animation
  • wrap demo app with gesture handler root view to support animations
  • remove pan handlers from calendar body components
  • add infinite pager to calendar container to support animations
  • change datetime utils to suopport adding multiple days based on page

fixes #138

Copy link

vercel bot commented Feb 5, 2025

@msvalandro is attempting to deploy a commit to the Kazuya Gosho's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-big-calendar ❌ Failed (Inspect) Feb 12, 2025 1:57pm

@acro5piano
Copy link
Owner

acro5piano commented Feb 8, 2025

@msvalandro Thanks! I'm looking forward to your work!

@msvalandro msvalandro marked this pull request as ready for review February 10, 2025 09:28
Copy link

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been using this version of the package with great success!

@msvalandro I think you can add "fixes #138" to the PR.

Copy link
Owner

@acro5piano acro5piano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This will definitely help a lot of people.

I'm considering we need extra introduction to our README or not - what do you think?

README.md Outdated
Comment on lines 454 to 468
Go to `rndemo/node_modules/react-native/third-party-podspecs/boost.podspec` and replace the code `spec.source = { :http => 'https://boostorg.jfrog.io...` for the code below:

```
spec.source = { :http => 'https://sourceforge.net/projects/boost/files/boost/1.83.0/boost_1_83_0.tar.bz2',
:sha256 => '6478edfe2f3305127cffe8caf73ea0176c53769f4bf1585be237eb30798c3b8e' }
```

Then run:

```sh
cd ios && NO_FLIPPER=1 pod install
cd ..
yarn ios
```

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need this - If this is required, I think we should add them in the main installation steps. Is it optional or to support old RN version? I'm suspicous our rndemo uses old version of RN.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this part since it's not directly related to the swipe animation. But I was not being able to run the demo app without making these changes (check facebook/react-native#42109 (comment))

I added some notes about the dependencies to run the calendar with animations. Let me know if you think there's something else missing @acro5piano

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The note is really helpful.

As a sidenote, lots of people are moving to Expo nowadays. I think we need to provide a proper way for Expo and make development effortless using it.

@acro5piano
Copy link
Owner

@msvalandro Thanks a lot! Could you fix the CI error? I think you can reproduce it on the local by yarn storybook or yarn build-storybook. Maybe either of them will be required:

  • Updating react-native-web
  • A stub or alias module for the added libraries

If none of them are possible, we should drop the web support or make this feature optional.

ERR! /vercel/path0/vercel/path0/node_modules/react-native-web/Libraries/Pressability/PressabilityDebug.ts doesn't exist
ERR! .tsx
ERR! Field 'browser' doesn't contain a valid alias configuration
ERR! /vercel/path0/vercel/path0/node_modules/react-native-web/Libraries/Pressability/PressabilityDebug.tsx doesn't exist
ERR! .js
ERR! Field 'browser' doesn't contain a valid alias configuration
ERR! /vercel/path0/vercel/path0/node_modules/react-native-web/Libraries/Pressability/PressabilityDebug.js doesn't exist
ERR! .jsx
ERR! Field 'browser' doesn't contain a valid alias configuration
ERR! /vercel/path0/vercel/path0/node_modules/react-native-web/Libraries/Pressability/PressabilityDebug.jsx doesn't exist
ERR! .json
ERR! Field 'browser' doesn't contain a valid alias configuration
ERR! /vercel/path0/vercel/path0/node_modules/react-native-web/Libraries/Pressability/PressabilityDebug.json doesn't exist
ERR! as directory
ERR! /vercel/path0/vercel/path0/node_modules/react-native-web/Libraries/Pressability/PressabilityDebug doesn't exist
info => Loading presets
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Command "yarn build-storybook" exited with 1

@msvalandro
Copy link
Author

@msvalandro Thanks a lot! Could you fix the CI error? I think you can reproduce it on the local by yarn storybook or yarn build-storybook. Maybe either of them will be required:

  • Updating react-native-web
  • A stub or alias module for the added libraries

If none of them are possible, we should drop the web support or make this feature optional.

Regarding the CI failing, I'm trying to integrate this lib (https://github.com/storybookjs/addon-react-native-web) into the storybook setup, I think this will handle the errors with 2 of the libraries I added: react-native-gesture-handler and react-native-reanimated. I couldn't finish this today, I'm having some errors with webpack, will continue to look at this tomorrow

@rishabh-synclovis
Copy link

When we can expect it will merge in main branch ?

@acro5piano
Copy link
Owner

@msvalandro
Thanks a lot!

@rishabh-synclovis
After the CI fix. Also I think this should be beta release of the next major version. Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swipe more naturally
4 participants