-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/support swipe animations #1135
base: main
Are you sure you want to change the base?
Feat/support swipe animations #1135
Conversation
@msvalandro is attempting to deploy a commit to the Kazuya Gosho's projects Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@msvalandro Thanks! I'm looking forward to your work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been using this version of the package with great success!
@msvalandro I think you can add "fixes #138" to the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This will definitely help a lot of people.
I'm considering we need extra introduction to our README or not - what do you think?
README.md
Outdated
Go to `rndemo/node_modules/react-native/third-party-podspecs/boost.podspec` and replace the code `spec.source = { :http => 'https://boostorg.jfrog.io...` for the code below: | ||
|
||
``` | ||
spec.source = { :http => 'https://sourceforge.net/projects/boost/files/boost/1.83.0/boost_1_83_0.tar.bz2', | ||
:sha256 => '6478edfe2f3305127cffe8caf73ea0176c53769f4bf1585be237eb30798c3b8e' } | ||
``` | ||
|
||
Then run: | ||
|
||
```sh | ||
cd ios && NO_FLIPPER=1 pod install | ||
cd .. | ||
yarn ios | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we need this - If this is required, I think we should add them in the main installation steps. Is it optional or to support old RN version? I'm suspicous our rndemo
uses old version of RN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this part since it's not directly related to the swipe animation. But I was not being able to run the demo app without making these changes (check facebook/react-native#42109 (comment))
I added some notes about the dependencies to run the calendar with animations. Let me know if you think there's something else missing @acro5piano
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The note is really helpful.
As a sidenote, lots of people are moving to Expo nowadays. I think we need to provide a proper way for Expo and make development effortless using it.
@msvalandro Thanks a lot! Could you fix the CI error? I think you can reproduce it on the local by
If none of them are possible, we should drop the web support or make this feature optional.
|
Regarding the CI failing, I'm trying to integrate this lib (https://github.com/storybookjs/addon-react-native-web) into the storybook setup, I think this will handle the errors with 2 of the libraries I added: |
When we can expect it will merge in main branch ? |
@msvalandro @rishabh-synclovis |
fixes #138