Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home): products section #10

Merged
merged 24 commits into from
Feb 14, 2024
Merged

feat(home): products section #10

merged 24 commits into from
Feb 14, 2024

Conversation

dohaki
Copy link
Collaborator

@dohaki dohaki commented Feb 13, 2024

Closes ACX-1869

Copy link

linear bot commented Feb 13, 2024

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
across-to ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 7:34am

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one question on the colors

@@ -22,7 +22,7 @@ export function StatBox({
<div className="group">
<div
className={twMerge(
"group flex flex-col rounded-2xl border border-grey-600 px-4 pb-6 transition sm:pb-10",
"group flex flex-col rounded-2xl border border-light-100/[.02] px-4 pb-6 transition sm:pb-10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to our theme?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea would make sense 🤔 In Figma, we don't have a name for this though. So using this opacity syntax might actually be better than coming up with some theme variable name. wdyt?

Base automatically changed from home-stats-section to master February 14, 2024 07:30
@dohaki dohaki merged commit 424ac53 into master Feb 14, 2024
3 of 4 checks passed
@dohaki dohaki deleted the home-products-section branch February 14, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants