-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(home): design, copy tweaks + subscribe section #20
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
const API_KEY = process.env.MAILCHIMP_API_KEY; | ||
const API_SERVER = process.env.MAILCHIMP_API_SERVER; | ||
const AUDIENCE_ID = process.env.MAILCHIMP_AUDIENCE_ID; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should place these in a constant file. Also, is this being done clientside?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this is only server-side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put them in constants file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for reviewing & discussing this offline.
No description provided.