Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plus): design tweaks and updates #21

Merged
merged 8 commits into from
Feb 20, 2024
Merged

fix(plus): design tweaks and updates #21

merged 8 commits into from
Feb 20, 2024

Conversation

dohaki
Copy link
Collaborator

@dohaki dohaki commented Feb 20, 2024

No description provided.

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
across-to ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 4:28pm

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one nit

Comment on lines +9 to +14
aqua: {
buttonClassName: "bg-aqua-100/[.05] text-aqua-100",
},
teal: {
buttonClassName: "bg-teal-100/[.05] text-teal-100",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen aqua-100/[.05] and teal-100/[.05] a few times. Thoughts on making these part of the style?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea at that point it would make sense! I will keep that in mind when refactoring

Base automatically changed from landing-page-tweaks to master February 20, 2024 16:25
@dohaki dohaki merged commit d5d6af0 into master Feb 20, 2024
4 checks passed
@dohaki dohaki deleted the plus-page-tweaks branch February 20, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants