-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plus): design tweaks and updates #21
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one nit
aqua: { | ||
buttonClassName: "bg-aqua-100/[.05] text-aqua-100", | ||
}, | ||
teal: { | ||
buttonClassName: "bg-teal-100/[.05] text-teal-100", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen aqua-100/[.05]
and teal-100/[.05]
a few times. Thoughts on making these part of the style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea at that point it would make sense! I will keep that in mind when refactoring
No description provided.