Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shared footer component #5

Merged
merged 8 commits into from
Feb 9, 2024
Merged

feat: add shared footer component #5

merged 8 commits into from
Feb 9, 2024

Conversation

dohaki
Copy link
Collaborator

@dohaki dohaki commented Feb 8, 2024

Based on #4, so mentioned PR needs to be reviewed first.

Closes ACX-1864

Copy link

linear bot commented Feb 8, 2024

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
across-to ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 2:27pm

Base automatically changed from base-version-nav-bar to master February 9, 2024 10:20
Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design looks properly implemented +1. I left one change that needs to happen on the URL

discord: {
label: "Discord",
description: "Access support and chat with community members",
href: "https://discord.com/invite/sKSkhTtu8s",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using discord.across.to so that we are pulling in the latest URL from the comms/marketing team.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dohaki dohaki merged commit 607dc49 into master Feb 9, 2024
4 checks passed
@dohaki dohaki deleted the footer-component branch February 9, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants