Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: partners carousel #6

Merged
merged 4 commits into from
Feb 13, 2024
Merged

feat: partners carousel #6

merged 4 commits into from
Feb 13, 2024

Conversation

dohaki
Copy link
Collaborator

@dohaki dohaki commented Feb 9, 2024

Closes ACX-1865

TBH this was pretty tricky to implement... I am not 100% sure if the animation is the desired one. There might also be better ways to implement this but this is the approach I could come up with:

  • Use custom CSS animation to transform and translate horizontally
  • Use an absolute position overlay to mimic fade-in/out effect

Copy link

linear bot commented Feb 9, 2024

Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
across-to ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 1:21pm

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - however, we need to pause the ticker on-hover. This is per Tim's walkthrough

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to refer to this as a Ticker since a Carousel is usually reserved for a slide-like component

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so these are basically slides that move automatically 🤔 But yea I can rename to Ticker if you think that fits better

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A ticker is a continuously moving group of elements that can repeat after the list is exhausted. The carousel is a moving slideshow of content.

Since we'll have both on this website, it may be helpful to differentiate it before we add the carousel

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok got it. But where do we have a carousel? Can't seem to find it in figma

Copy link
Contributor

@james-a-morris james-a-morris Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Across+ page:
image

The blue bar underneath "Add Liquidity" is a countdown timer before the next slide is shown

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments - looks great 🔥

@dohaki
Copy link
Collaborator Author

dohaki commented Feb 12, 2024

LGTM - however, we need to pause the ticker on-hover. This is per Tim's walkthrough

Hmm, so it should pause on the exact slide I assume right? 🤔

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more comments

@dohaki dohaki merged commit 789174c into master Feb 13, 2024
4 checks passed
@dohaki dohaki deleted the partners-carousel branch February 13, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants