Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blog): homepage #60

Merged
merged 9 commits into from
Sep 10, 2024

Conversation

james-a-morris
Copy link
Contributor

@james-a-morris james-a-morris commented Aug 29, 2024

This adds just the homepage section of the blog work. The carousel aspect was pushed to a later date per a sync with design. The Filter is in progress and will be handled in a follow-up PR to add search functionality.

Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Copy link

linear bot commented Aug 29, 2024

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
across-to ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 3:08am

Signed-off-by: james-a-morris <[email protected]>
@james-a-morris james-a-morris force-pushed the james/acx-2025-build-out-blog-homepage branch from c7d88a6 to 3c96d06 Compare August 29, 2024 20:07
@james-a-morris james-a-morris marked this pull request as ready for review August 29, 2024 20:08
@james-a-morris james-a-morris changed the title James/acx 2025 build out blog homepage feat(blog): homepage Aug 29, 2024
Copy link

@amateima amateima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be merged without the Search functionality done?

* feat(blog): add search feature

Signed-off-by: james-a-morris <[email protected]>

* chore: keyword search

Signed-off-by: james-a-morris <[email protected]>

---------

Signed-off-by: james-a-morris <[email protected]>
Copy link
Collaborator

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code looking good 👍 Do we have designs for an empty search screen though?
image

Maybe just something like "No results" would suffice for now. But just a nit

src/app/(routes)/blog/_components/section-container.tsx Outdated Show resolved Hide resolved
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
@james-a-morris
Copy link
Contributor Author

Nice code looking good 👍 Do we have designs for an empty search screen though? image

Maybe just something like "No results" would suffice for now. But just a nit

ca2ed6e

@james-a-morris james-a-morris merged commit e98f5fb into staging-blog Sep 10, 2024
4 checks passed
james-a-morris added a commit that referenced this pull request Oct 1, 2024
* chore: add aria-description

Signed-off-by: james-a-morris <[email protected]>

* chore: first layout

Signed-off-by: james-a-morris <[email protected]>

* chore: item cards

Signed-off-by: james-a-morris <[email protected]>

* chore: update homepage

Signed-off-by: james-a-morris <[email protected]>

* improve: add tailwind hide utility

Signed-off-by: james-a-morris <[email protected]>

* fix: linting & suspense wrap

Signed-off-by: james-a-morris <[email protected]>

* feat(blog): add search feature (#61)

* feat(blog): add search feature

Signed-off-by: james-a-morris <[email protected]>

* chore: keyword search

Signed-off-by: james-a-morris <[email protected]>

---------

Signed-off-by: james-a-morris <[email protected]>

* chore: remove empty file

Signed-off-by: james-a-morris <[email protected]>

* nit: add no results copy

Signed-off-by: james-a-morris <[email protected]>

---------

Signed-off-by: james-a-morris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants