-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blog): add search feature #61
Merged
james-a-morris
merged 2 commits into
james/acx-2025-build-out-blog-homepage
from
james/acx-2592-build-out-search-page
Sep 6, 2024
Merged
feat(blog): add search feature #61
james-a-morris
merged 2 commits into
james/acx-2025-build-out-blog-homepage
from
james/acx-2592-build-out-search-page
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: james-a-morris <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gsteenkamp89
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
@@ -23,39 +30,30 @@ export default async function BlogHomePage() { | |||
getStartedSlugs.map((s) => retrieveContentfulEntry(s)), | |||
); | |||
|
|||
const key = createCacheKey({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add this key to Suspense
Signed-off-by: james-a-morris <[email protected]>
james-a-morris
merged commit Sep 6, 2024
e8f474b
into
james/acx-2025-build-out-blog-homepage
4 checks passed
james-a-morris
added a commit
that referenced
this pull request
Sep 10, 2024
* chore: add aria-description Signed-off-by: james-a-morris <[email protected]> * chore: first layout Signed-off-by: james-a-morris <[email protected]> * chore: item cards Signed-off-by: james-a-morris <[email protected]> * chore: update homepage Signed-off-by: james-a-morris <[email protected]> * improve: add tailwind hide utility Signed-off-by: james-a-morris <[email protected]> * fix: linting & suspense wrap Signed-off-by: james-a-morris <[email protected]> * feat(blog): add search feature (#61) * feat(blog): add search feature Signed-off-by: james-a-morris <[email protected]> * chore: keyword search Signed-off-by: james-a-morris <[email protected]> --------- Signed-off-by: james-a-morris <[email protected]> * chore: remove empty file Signed-off-by: james-a-morris <[email protected]> * nit: add no results copy Signed-off-by: james-a-morris <[email protected]> --------- Signed-off-by: james-a-morris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.