-
Notifications
You must be signed in to change notification settings - Fork 71
chore: Consolidated OP chain spoke pools #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
e77ce5a
0cdef07
ef99c87
20965ea
590fffc
be08e44
fd2319d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,10 +6,10 @@ import "./Ovm_SpokePool.sol"; | |
import "./external/interfaces/CCTPInterfaces.sol"; | ||
|
||
/** | ||
* @notice Bob Spoke pool. | ||
* @notice OP Spoke pool. | ||
* @custom:security-contact [email protected] | ||
*/ | ||
contract Bob_SpokePool is Ovm_SpokePool { | ||
contract OP_SpokePool is Ovm_SpokePool { | ||
/// @custom:oz-upgrades-unsafe-allow constructor | ||
constructor( | ||
address _wrappedNativeTokenAddress, | ||
|
@@ -28,7 +28,7 @@ contract Bob_SpokePool is Ovm_SpokePool { | |
{} // solhint-disable-line no-empty-blocks | ||
|
||
/** | ||
* @notice Construct the Bob SpokePool. | ||
* @notice Construct the OP SpokePool. | ||
* @param _initialDepositId Starting deposit ID. Set to 0 unless this is a re-deployment in order to mitigate | ||
* relay hash collisions. | ||
* @param _crossDomainAdmin Cross domain admin to set. Can be changed by admin. | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one probably isn't the best candidate here, since it supports neither bridged nor native USDC. I think the Base SpokePool probably would be a better choice.
All of this is subject to whether there's a larger overhaul on the SpokePools wrt. bridge adapter modularity and configuration. But I think it makes sense to have a PR that handles the consolidation anyway, since it's basically inevitable that we delete these.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't all the spoke pools being deleted here the same up to comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes its just comment diff on all these spoke pool, in this case I think github randomly picked Bob to show as name change