Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Sepolia testnet details #316

Merged
merged 5 commits into from
Jul 17, 2023
Merged

chore: Add Sepolia testnet details #316

merged 5 commits into from
Jul 17, 2023

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Jul 17, 2023

These contract addresses are needed by relayer-v2 for testing.

@pxrl pxrl requested a review from nicholaspai July 17, 2023 11:38
Comment on lines 171 to 170
// sepolia: process.env.ETHERSCAN_API_KEY!, hardhat-etherscan is unhappy with custom definitions.
optimisticEthereum: process.env.OPTIMISM_ETHERSCAN_API_KEY!,
arbitrumOne: process.env.ARBITRUM_ETHERSCAN_API_KEY!,
polygon: process.env.POLYGON_ETHERSCAN_API_KEY!,
polygonMumbai: process.env.POLYGON_ETHERSCAN_API_KEY!,
},
customChains: [],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to remove the definition for sepolia because we inherit a very old version of hardhat-etherscan from @uma/common, and it doesn't support customChains.

I can't see any obvious way of preventing UMA's hardhat dependencies from executing, and intuitively it seems wrong that we inherit this requirement to our environment from an external package. I've commented sepolia out for now, but it'd be good to address the underlying issue.

yarn run v1.22.19                                                                                               
$ hardhat compile && tsc && rsync -a --include '*/' --include '*.d.ts' --exclude '*' ./typechain ./dist/        
Error in plugin @nomiclabs/hardhat-etherscan: Etherscan API token "sepolia" is for an unsupported network                                                                                                                        
                                                                                                                
Learn more at https://hardhat.org/plugins/nomiclabs-hardhat-etherscan.html#multiple-api-keys-and-alternative-block-explorers                                                                                                     
                                                                                                                                                                                                                                 
NomicLabsHardhatPluginError: Etherscan API token "sepolia" is for an unsupported network                                                                                                                                         
                                                                                                                                                                                                                                 
Learn more at https://hardhat.org/plugins/nomiclabs-hardhat-etherscan.html#multiple-api-keys-and-alternative-block-explorers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually should not being using hardhat-etherscan anymore to verify. The latest package we should be using is hardhat-verify: https://github.com/across-protocol/contracts-v2/blob/master/package.json#L53

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - we're not actually intending to use hardhat-etherscan. We seem to be inheiriting it via @uma/common, and I haven't found any way to inhibit that.

hardhat.config.ts Outdated Show resolved Hide resolved
optimisticEthereum: process.env.OPTIMISM_ETHERSCAN_API_KEY!,
arbitrumOne: process.env.ARBITRUM_ETHERSCAN_API_KEY!,
polygon: process.env.POLYGON_ETHERSCAN_API_KEY!,
polygonMumbai: process.env.POLYGON_ETHERSCAN_API_KEY!,
},
customChains: [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need this for ZkSync did this auto remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah; no. I removed it because we can't actually use it, per the issue above about hardhat-etherscan. I'll restore it.

@pxrl pxrl requested a review from nicholaspai July 17, 2023 13:59
@pxrl pxrl merged commit e10eb0f into master Jul 17, 2023
@pxrl pxrl deleted the pxrl/sepolia branch July 17, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants